search

SolomonDefi / solomon-monorepo

Monorepo containing core Solomon apps, services, libraries, and deploy config.
6 stars 4 forks source link

Impl nest api #237

Closed apolkingg8 closed 2 years ago

apolkingg8 commented 2 years ago

related #224

apolkingg8 commented 2 years ago

@solomondefi-dev Please don't put your effort and comment on a draft PR. I create this for my self-review and I can't reply to something not complete yet.

solomondefi-dev commented 2 years ago

It's no effort, don't worry! Just a couple seconds to scan through. The code comment is not actually relevant to this PR, I just happened to see the LoggerService and wanted to point out something that could be useful.

apolkingg8 commented 2 years ago

@solomondefi-dev Since you said you don't want the PR to be too big, I'll stop here. I've temporarily commented out the dbService tests because there is still some CI environment and db init script needs to be set up, so you can skip this unfinished part when you view it.

Also, I changed the test script - for a long time we were using the wrong test script, so many tests were not actually being run. This PR contains some test fixes (some of which are out of my scope), please check them.

apolkingg8 commented 2 years ago

Split db migrate into #238