Closed apolkingg8 closed 2 years ago
@solomondefi-dev Please don't put your effort and comment on a draft PR. I create this for my self-review and I can't reply to something not complete yet.
It's no effort, don't worry! Just a couple seconds to scan through. The code comment is not actually relevant to this PR, I just happened to see the LoggerService
and wanted to point out something that could be useful.
@solomondefi-dev Since you said you don't want the PR to be too big, I'll stop here. I've temporarily commented out the dbService
tests because there is still some CI environment and db init script needs to be set up, so you can skip this unfinished part when you view it.
Also, I changed the test script - for a long time we were using the wrong test script, so many tests were not actually being run. This PR contains some test fixes (some of which are out of my scope), please check them.
Split db migrate into #238
related #224