SolraBizna / j6502

Cycle-accurate W65C02 emulator in Java
Other
2 stars 1 forks source link

Fix text overflowing horizontally by one character #3

Open atirut-w opened 2 years ago

atirut-w commented 2 years ago

Original bug:

Screenshot_20220604_213903

Original text for the second to third line: [...] sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. [...]

TODO: Test this PR. I don't have any idea how to compile Minecraft mods atm so someone else will have to do it.

SolraBizna commented 2 years ago

I think a simpler fix would be to change line 842 from:

if(newCursorX > (curW&0xFF)) {

to:

if(newCursorX >= (curW&0xFF)) {

(I can't test or build either change unless Microsoft changes their account recovery policy.)

atirut-w commented 2 years ago

Sad

On Sun, 5 Jun 2022, 03:48 Solra Bizna, @.***> wrote:

I think a simpler fix would be to change line 842 from:

if(newCursorX > (curW&0xFF)) {

to:

if(newCursorX >= (curW&0xFF)) {

(I can't test or build either change unless Microsoft changes their account recovery policy.)

— Reply to this email directly, view it on GitHub https://github.com/SolraBizna/j6502/pull/3#issuecomment-1146683735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGBGNXYW5VVPLNMOPHKW4ZDVNO6K5ANCNFSM5X3RSCFA . You are receiving this because you authored the thread.Message ID: @.***>

SolraBizna commented 2 years ago

I dusted off Java Bytecode Editor and replaced the relevant if_cmple with an if_cmplt. Does the attached edited version of the mod still exhibit the problem?

OCMOS-MC1.7.10-0.5.3.jar.zip

atirut-w commented 2 years ago

Screenshot_20220605_115749

I guess the bug is somewhere else. The text still disappears into side side but now it's like this.

SolraBizna commented 2 years ago

Very strange. If you put the old version of the mod back, do those four spaces disappear?

atirut-w commented 2 years ago

Ah, those spaces in the beginning was my fault. It was copied along the Lorem Ipsum

On Sun, 5 Jun 2022, 12:10 Solra Bizna, @.***> wrote:

Very strange. If you put the old version of the mod back, do those four spaces disappear?

— Reply to this email directly, view it on GitHub https://github.com/SolraBizna/j6502/pull/3#issuecomment-1146743110, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGBGNX4XMACLMVNDABWW3TLVNQZFRANCNFSM5X3RSCFA . You are receiving this because you authored the thread.Message ID: @.***>

atirut-w commented 2 years ago

The fuck, GMail?????? It got sent just today??