SolsticeSpectrum / Incredibox

A source code of Incredibox extracted from Android app
https://darkreaper231.github.io/Incredibox
21 stars 21 forks source link

MODULE_NOT_FOUND when trying to create package #7

Open muzzol opened 10 months ago

muzzol commented 10 months ago

I'm following this instructions: https://github.com/DarkReaper231/Incredibox/tree/modding/desktop

and I get this error when I execute node run package:linux


node:internal/modules/cjs/loader:1042
  throw err;
  ^

Error: Cannot find module '/home/muzzol/inst/incredibox/Incredibox-modding/desktop/run'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1039:15)
    at Module._load (node:internal/modules/cjs/loader:885:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v18.13.0
muzzol commented 10 months ago

I managed to create an AppImage file with these commands:


sudo npm install -g electron-builder
sudo electron-builder -l

I'm not sure if this is the correct way to create a package on linux but works for me.

SolsticeSpectrum commented 10 months ago

@muzzol have you execute node run package:linux in terminal?

muzzol commented 10 months ago

yes, that output is from the terminal:

muzzol@zion:~/inst/incredibox/Incredibox-modding/desktop$ node run package:linux
node:internal/modules/cjs/loader:1042
  throw err;
  ^

Error: Cannot find module '/home/muzzol/inst/incredibox/Incredibox-modding/desktop/run'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1039:15)
    at Module._load (node:internal/modules/cjs/loader:885:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v18.13.0
muzzol@zion:~/inst/incredibox/Incredibox-modding/desktop$ 

I'm on debian:

$ lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 12 (bookworm)
Release:    12
Codename:   bookworm
SolsticeSpectrum commented 10 months ago

@muzzol The MODULE_NOT_FOUND error seems to happen when changing between node versions and some files are possibly still being cached.

SolsticeSpectrum commented 10 months ago

I'll test it more tomorrow

muzzol commented 10 months ago

@muzzol The MODULE_NOT_FOUND error seems to happen when changing between node versions and some files are possibly still being cached.

makes sense, I installed some packages with apt and some others directly with npm. so the conflict can be there. but in theory when you execute npm i all versioning is checked, right?

SolsticeSpectrum commented 10 months ago

@muzzol The MODULE_NOT_FOUND error seems to happen when changing between node versions and some files are possibly still being cached.

makes sense, I installed some packages with apt and some others directly with npm. so the conflict can be there. but in theory when you execute npm i all versioning is checked, right?

Hey sorry for not replying for long time, I didn't have time to look into it but I do have time now. I am not sure if npm i checks system packages

SolsticeSpectrum commented 10 months ago

@muzzol no wonder it does not work, I did a mistake in the readme, it's npm run package:linux not node run package:linux, can you test using npm instead of node and report back?

muzzol commented 10 months ago

sorry, I don't have a fresh machine to test it right now.

but I think you can close the issue and I'll comment if something goes wrong.

thanks a lot for your time!