SolteraGG / feedbapp

A bot for submitting anonymous comments to the dddMC Administrators.
0 stars 0 forks source link

Command module loading #3

Open kaylendog opened 3 years ago

kaylendog commented 3 years ago

From #2, @kokumaji added support for loading commands directly from the file system. This has somepotential ramifications - nothing inherently wrong with doing it, but it does come at the cost of some type safety.

We can either:

Both sides have their pros and cons, but needs discussing to work out what to do.

kokumaji commented 3 years ago

I talked to @vladfrangu about this and they suggested https://sapphiredev.github.io/framework as an alternative, the current implementation is really just something I'm familiar with that works. Of course a proper command handler is a better approach

kaylendog commented 3 years ago

I talked to @vladfrangu about this and they suggested https://sapphiredev.github.io/framework as an alternative, the current implementation is really just something I'm familiar with that works. Of course a proper command handler is a better approach

If Vlad wants to use his own library, he can. Given there's still like, no documentation for Sapphire aside from the auto-generated typedocs, it's not something I would suggest we use.

vladfrangu commented 3 years ago

Leaving aside the fact it's not my library, I don't see why that affects anything, when the entire library is so small and extensible, it only adds small helper stones... THere's also a bunch of bots already using it, whose code is OSS, so...

kaylendog commented 3 years ago

Leaving aside the fact it's not my library, I don't see why that affects anything, when the entire library is so small and extensible, it only adds small helper stones... THere's also a bunch of bots already using it, whose code is OSS, so...

Oh please, we know you contribute to it. The lack of documentation is like a really big problem - reading OSS code is only going to get some of us so far.