search

SolutionGuidance / psm-dashboard

Dashboard for displaying information about PSM project status.
GNU Affero General Public License v3.0
2 stars 1 forks source link

Stop requiring psm_req's caller to convert to CSV first #14

Closed kfogel closed 6 years ago

kfogel commented 6 years ago

Currently, users of the psm_reqs Python module are expected to first convert the requirements to CSV format (using xlsx2csv) and then initialize by calling psm_reqs.get_reqs(csv_file). This is a case of implementation poking through the API in an inappropriate way. Instead, psm_reqs should handle it all internally: the user should just call psm_reqs.get_reqs("/path/to/RTM.xlsx") and the module would (transparently, in the background) use the Python subprocess module to invoke xlsx2csv itself and parse the requirements from the resultant CSV stream.

One kluge resulting from the current situation is that refresh-dashboard pretend-parses psm-dashboard-config.json to get the value of the "psm_reqs" parameter, just to build a CSV and hand it off to psm_reqs.

kfogel commented 6 years ago

Not sure why this is still open; @pjsier's changes above should have closed it. Closing now.