SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 20 forks source link

Use "Limited" instead of "Low" for consistent UI risk levels #1013

Closed PaulMorris closed 6 years ago

PaulMorris commented 6 years ago

"Limited" was used in more places in the UI, is the language in the requirements docs, and is used in the underlying code. This also fixes a bug: filtering for "Low" (with provider login) was not working, but filtering for "Limited" does work.

Tested by logging in as an admin and seeing "Limited" instead of "Low" the enrollment tables in the "Risk Levels" column. And by logging in as a provider and seeing "Limited" instead of "Low" when filtering the enrollments tables, and checking that this filter option works as expected.

I checked the change in the service_agent_print_enrollments.jsp by going to the search results page (quick or admin) and clicking the Print button at the top of the table, then seeing "Limited" in the table on the printable page that opens in a new tab.

Resolves #862 Standardize on 'Low' vs 'Limited' risk level

PaulMorris commented 6 years ago

Good call! I've added that change in a new commit.

PaulMorris commented 6 years ago

Jenkins, test this please.

PaulMorris commented 6 years ago

Hmmm, the two unit test failures are unrelated to this PR, so I'm going to go ahead and merge. The two failing unit tests (ProviderDashboardControllerTest) were removed in PR #1016 , so it looks like a stale cache type problem.