search

SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 20 forks source link

Use the handlebars pagination templates in more places #1016

Closed PaulMorris closed 6 years ago

PaulMorris commented 6 years ago

Fix #1007 by using the handlebars templates for pagination widgets instead of the JSP templates, moving quite close to being able to remove the buggy JSP templates. This involves both the 1 2 3 4 5 Next >> widget and the Showing 1 of 10 widget.

Tested by going to the Enrollments pages and the search results pages for both provider and service admin logins and confirming that all the pagination widgets look and work as expected. Also by logging in as a service admin and going to Functions > Provider Types and Functions > Agreements... and testing the 1 2 3 4 5 Next >> widgets on those pages as well.

There is some follow-up work to do to finish the job, but I wanted to go ahead and get this up for review since it gets us to a better place and fixes of the user-visible glitches.

Resolves #1007: Glitches in pagination widget for service admin tables

PaulMorris commented 6 years ago

Ah, those commit messages may not have been clear, but they were describing the glitches I saw when I tried to use the other handlebars template on those pages (the Showing 1 of 10 one), and so why I had left it out of those commits. That's part of the follow-up work to finish off the consolidation and then removal of the JSP templates.