search

SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 20 forks source link

Improve "Same as Above" behavior #1028

Open PaulMorris opened 6 years ago

PaulMorris commented 6 years ago

@kfogel writes in Zulip:

Click "same as above" in Contact Info doesn't reassuringly fill in the bottom fields with that same info, which would be the normal behavior for that kind of field.

PaulMorris commented 5 years ago

Related: in cases where different fields are required or not depending on whether "same as above" is toggled on or off, then the required asterisks should respond accordingly, both inside and outside the "same as above" section.

For example, after PR #987 (fixing issue #842) the asterisk outside that "save as above" section appears and disappears, but not the asterisks inside that section. Quoting myself from PR #987:

One thing I noticed that would be good to do in a follow-up is that checking "same as above" now toggles one required asterisk on/off, but the two that are below "same as above" do not toggle on/off. So you have fields that stay marked as required that aren't actually required (when "same as above" is checked). We should toggle all of these asterisks for consistency.

But! if we're filling in the info in the "same as above" section as @kfogel describes above, then we probably don't need to toggle asterisks hidden/visible.