Every time I came across one of these warnings, I felt the desire to clean them up. Sometimes I was able to resist, and sometimes I did the refactoring and stuck it on a branch, and having so cleaned up, I could return to the task at hand. It's time to get those experimental branches merged, though, so here we are.
These refactorings are fairly mechanical, and will hopefully not overlap with @frankduncan's other pull requests; to that end, I specifically avoided touching ProviderEnrollmentServiceBean!
Every time I came across one of these warnings, I felt the desire to clean them up. Sometimes I was able to resist, and sometimes I did the refactoring and stuck it on a branch, and having so cleaned up, I could return to the task at hand. It's time to get those experimental branches merged, though, so here we are.
These refactorings are fairly mechanical, and will hopefully not overlap with @frankduncan's other pull requests; to that end, I specifically avoided touching
ProviderEnrollmentServiceBean
!Issue #915 Use static analysis to find bugs