search

SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 20 forks source link

Improve advanced search panel layout and remove colons #1069

Closed PaulMorris closed 5 years ago

PaulMorris commented 5 years ago

The same advanced search panel appears for both provider and service admin logins.

Before (yikes...):

screenshot_2018-08-29 advanced search 1

After:

screenshot_2018-08-29 advanced search 2

The CSS changes also slightly affect (in a slightly positive way, IMHO) the system admin advance search panel. Before:

screenshot_2018-08-29 advanced search system admin

After:

screenshot_2018-08-29 advanced search system admin 2

Tested by logging in and looking at the advanced search pages for the three logins.

Issue #376: Remove right-justified colons...

kfogel commented 5 years ago

This looks good to me. Just my usual question: we know that the CSS portion of the changes don't have unintended effects anywhere else?

kfogel commented 5 years ago

This looks good to me. Just my usual question: we know that the CSS portion of the changes don't have unintended effects anywhere else?

Also: might have been good to separate the colon-removal portion of this from the other stuff, since colon removal is its own thang (issue #376). I think that's not hard to do -- just a rebase and a new PR, right?

PaulMorris commented 5 years ago

@kfogel Yeah, CSS changes only affect the pages mentioned above. Good call on splitting off the colon removal from the layout changes. That will be easy to do. I'll open a new PR for the layout edits.

PaulMorris commented 5 years ago

CSS layout changes split off into PR #1081.