SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 18 forks source link

Improve the Upload File UI in more places #1074

Closed jasonaowen closed 6 years ago

jasonaowen commented 6 years ago

When we were working on #158, I had some work partially completed to implement the new upload file UI in more places. Then that work got deprioritized, and it sat on a branch, alone and unloved.

I haven't yet tested these, and they might be quite broken! The first step is to figure out which forms, exactly, I'm updating; hopefully the commit titles make that clear. Then you need to figure out how to get to each form...

I open this PR in the hope that they aren't broken, and that someone has time to test them. Please merge, tweak, rewrite, or close as you see fit, dear reviewer; I'm afraid I likely won't have the time to.

Issue #158 "No file selected" is confusing when a file is uploaded Issue #734 Moving backward in PHN enrollment loses county contract

PaulMorris commented 6 years ago

I did some testing with this today, and found that 3 of these work as expected. With the other 2, you can submit and the file name shows up as expected, but when you save as draft or move away from that page and go back, the button says "upload" and there's no file name or download link, as if you hadn't uploaded the file. The ones that currently work are social worker, PCPO, and day treatment. The ones that need more work are Physician Clinic and Public Health Nursing Organization.

We could either split this up and go ahead and land the ones that work and tackle the others in a follow-up, or if it's easy enough to fix them, go ahead and do that with this PR.

PaulMorris commented 6 years ago

Closing. Commits split into PR #1088 and #1089.