SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 20 forks source link

Remove print links and buttons (fix 1046) #1078

Closed PaulMorris closed 5 years ago

PaulMorris commented 5 years ago

Remove print links in the enrollments action column for providers and service admins. Remove print buttons throughout the application, including enrollment summary pages, view enrollment details pages, view profile pages, enrollment search pages, etc. Remove code for print buttons and print modals now that they are no longer used. Add "Export to PDF" buttons to replace the print buttons on the application summary pages.

Tested by checking that the pages no longer had print buttons and that the new "Export to PDF" buttons on the summary pages worked as expected. (Some parts of the summary are not present in the PDF, the headings are there but not the details, which appears to be a bug with the export to pdf functionality. We can open another issue for this.)

One print button remains for printing Agreements and Addendums (service admin > Functions > Agreements and Addendums > view). I left this one in until we can replace it with an export to pdf button -- another follow-up issue to file.

Before: screenshot_2018-08-30 all enrollments 2

After: screenshot_2018-08-30 all enrollments

xxxxxxxxxxxxxxxxxxxx

Before: screenshot_2018-08-30 all enrollments 3

After: screenshot_2018-08-30 all enrollments 1

xxxxxxxxxxxxxxxxxxxx

Before: screenshot_2018-08-30 personal information

After: screenshot_2018-08-30 organization information

xxxxxxxxxxxxxxxxxxxx

Before: screenshot_2018-08-30 summary information 1

After: screenshot_2018-08-30 summary information

Issue #1046 Get rid of Print links, just use Export-to-PDF

PaulMorris commented 5 years ago

Thanks @frankduncan , I added a few more commits to remove the unused traces of print functionality and also those unused 'viewCopyModal' CSS styles that you found:

Remove a couple of unused traces of print functionality 498b878 Remove unused '#viewCopyModal' CSS styles 88a7481 Rename 'print-header.png' to 'dark-blue-modal-header.png' 89a2398 Remove unused styles for 'print-icon-blue.png' background 7877ba7

Build succeeds for me locally, but I see it failed on Jenkins. Not sure why. I clicked through to details but I didn't see a reason for the failure.

Oh, here it is: https://ci.psm.solutionguidance.com/job/build/882/console Will try again.

PaulMorris commented 5 years ago

Jenkins, test this please.