SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 20 forks source link

Implement screenings page functionality rework #1080

Closed PaulMorris closed 5 years ago

PaulMorris commented 5 years ago

This is further work on @HemKal 's PR #1077, addressing the points from my review there, namely:

I rebased most of these changes into the initial commit. I also added a JS alert for the WIP 'auto screen' link rather than let users hit system errors, and reworded the 'reason' shown for manual rejections. All of this is just polish on the original work, which was described as:

Following Items are functional in this commit -Date Range and Status Filter -Data fetched from DB -Tabs Functional -Format dates in the table -View Application Link is added -Screening links are hooked to proper controllers (Auto screen is WIP) -Limit initial fetch to last 30 days of screenings

Tested by logging in as a service admin and clicking around the screenings page to see that everything works as expected. Pagination widgets remain to be wired up in a follow-up effort.

Before:

screenshot_2018-09-04 screenings 1

With PR #1077:

screenshot_2018-09-04 screenings

After:

screenshot_2018-09-04 screenings 2

Issue #933 Improve the admin Screenings page

PaulMorris commented 5 years ago

Fixed unit test failures by updating AutomaticScreeningControllerTest.groovy (in commit https://github.com/SolutionGuidance/psm/pull/1080/commits/1b347a637aea6f6aa1cfc1bdb97e612fb74bb663) so that the constructor for the AutomaticScreeningController in the test gets two mocked parameters (it only had one before, so now it needs both). Also fixed a tiny JS code style issue.

PaulMorris commented 5 years ago

Thanks for the review @jasonaowen ! Definitely helpful, all good points, will revise.

PaulMorris commented 5 years ago

I've made the changes @jasonaowen suggested except for adding unit tests for the view method of AutomaticScreeningController. Will check with @kfogel on prioritizing doing that here or as a follow-up.

While at it I fixed the screening type so it will correctly display "LEIE" or "DMF" now that the DMF work has landed (an easy fix). I also changed the wording of the action column links. "Auto Screen" -> "Run Again" to avoid confusion of "I manually ran an automatic screen". And "Manual Screen" -> "Review" for consistency since the link currently takes you to the application review page.

screenshot_2018-09-06 screenings

frankduncan commented 5 years ago

My commits can be reviewed

frankduncan commented 5 years ago

I did the final cleanups. If you think we're good to go @PaulMorris , go ahead and merge it :)