SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 20 forks source link

Improve the Upload File UI on three pages #1088

Closed PaulMorris closed 5 years ago

PaulMorris commented 5 years ago

These commits are from @jasonaowen 's PR #1074. These commits/pages worked as expected, while the other two in PR #1074 did not, so I'm separating the work out into separate PRs.

This PR removes some CSS styles to fix a visual glitch I noticed on the Day Treatment and PCPO applications. I think the removed styles were originally for the spans with right-aligned colons that are no longer there. (What else would need to be so narrow?) They were causing the license file name ('my-license.txt') to be split onto multiple lines:

screenshot_2018-09-17 facility credentials

Here it is fixed:

screenshot_2018-09-17 facility credentials 1

Those two screenshots above show the three states of the upload button. Before upload, immediately after upload (where the file title is shown), and after saving or moving away from the page (when "Download" link is shown). The next 3 show each of these in separate screenshots:

screenshot_2018-09-17 facility credentials 2

screenshot_2018-09-17 facility credentials 3

screenshot_2018-09-17 facility credentials 4

And the same for the social worker application:

screenshot_2018-09-17 license information

screenshot_2018-09-17 license information 1

screenshot_2018-09-17 license information 2

Issue #158 "No file selected" is confusing when a file is uploaded

PaulMorris commented 5 years ago

Jenkins, test this please.