search

SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 18 forks source link

Remove remaining unneeded colons #1093

Closed PaulMorris closed 6 years ago

PaulMorris commented 6 years ago

I have not been able to locate and access these pages in our current UI (thus, no screenshots). So I suggest that we go ahead and remove these colons since 1. we have not run into any serious formatting issues when removing these kinds of colons elsewhere and 2. it seems unlikely that these pages are currently accessible, so there's no real risk or reason not to go ahead and remove them.

Details: Two of these JSPs are for COS (Category of Service) functionality, which is no longer exposed in the UI. Most of the others appear to be pages that might have, at some point, been accessible via the 'service agent' role, a role that we are likely removing (per previous discussions with @cecilia-donnelly and @jasonaowen ). The last one, that is not 'service agent' related, (onboarding/create_link) involves linking to external accounts, which is also functionality we are not currently supporting.

These are the last of these colons that we want to remove.

Resolves #376: Remove right-justified colons...

frankduncan commented 6 years ago

And I worked my way down the PR list, and not up it. So this is the final of them. Sorry about the erroneous comment!