search

SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 18 forks source link

Remove or complete Categories of Service (COS) #711

Open cecilia-donnelly opened 6 years ago

cecilia-donnelly commented 6 years ago

The "COS" action is incompletely implemented and not mentioned in the RTM. I believe we should remove it unless we know of a compelling reason it should be included in the PSM.

If we do keep it, then we should write help text to cover this area of the application.

PaulMorris commented 6 years ago

The "COS" links will be removed from the UI in PR #1002. Documenting what the UI looks like here.

The "COS" links were in the Action column on the service admin Enrollments pages and Search Results pages (for advanced and quick search):

screenshot_2018-08-03 draft enrollments 2

And the links pointed to this "Category of Service" page:

screenshot from 2018-08-03 17-07-37

frankduncan commented 6 years ago

Before #949, there were two kinds of categories_of_service, one that lived on the profile, and one that lived on the enrollment. These were pendingCOS and just plain COS. After #949, categories of service are only attached to enrollments, and not profiles.

In the case that the business requirements are that this goes the other way (you can't have both), the implementer will have to swap that column in the database, and remove the code having to do with profiles.

After #949, the code will be left in that allows you to potentially add to either, but it will throw exceptions because this isn't fully implemented.

jasonaowen commented 6 years ago

Follow up to #1002: we should delete the @ignored integration test, and the code backing its steps.

PaulMorris commented 6 years ago

Ah, good catch @jasonaowen ! I'll add that to my TODOs. Edit: done in PR #1008