SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 18 forks source link

Reviewer clicking "approve" does not always approve enrollment #875

Open jasonaowen opened 6 years ago

jasonaowen commented 6 years ago

As a state reviewer, when I click on the "Approve" button on the review page for an enrollment application, I expect either an immediate error or for the enrollment application to be approved.

Instead, sometimes, the enrollment is not approved, and is confusingly left in a pending state without giving any feedback.


Part of the cause of this problem is the way the Drools rules are integrated. Clicking "approve" causes the screening rules to be re-run, and if they all pass, the enrollment application is approved; if any of them fail, the application is silently left in a pending state.

See also issue #354, which relates to how automatic screenings are related, and issue #572, which relates to the Drools rules being run (and mentions this problem as a parenthetical).

frankduncan commented 6 years ago

To re-create:

Add enrollment with no leie running (causing an error). Go to enrollment, review, and without checking the manual override box for the leie error, hit "approve."