search

SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 20 forks source link

Remove or rework and reuse "domain"-specific login code #931

Open PaulMorris opened 6 years ago

PaulMorris commented 6 years ago

This is a follow-up on issue #911. PR #922 removed the 'domain' selector from the login page, but left most of the code backing this feature in place. The code should either be removed or reworked in order to provide the domain-specific login feature (at some future point when it is relevant).

A quote from #911 about the feature:

The "Domain" is probably an authorization domain that we may not be able to determine automagically from the username -- because usernames might be unique only within a given domain (unless the PSM enforces otherwise, which is not a decision we've made). For example, some users might need to authorize against an internal MMIS authn source, others against some agency-specific or group-specific provider database, still others against a state admin LDAP source, etc.

However, the UI could do a better job of making this clear, and of guiding the user to choose the right authn source.

Furthermore, right now we're pretty sure Domain isn't being used. We could just comment out that whole block on the login page template and it'd be fine. Until we support domains, there's no reason to confuse users with them (and we'll be better able to design the UI when we have the real use case in hand).

PaulMorris commented 6 years ago

A couple relevant comments from #911:

@frankduncan wrote:

If you pull on this thread, you may run into external_home.jsp and all the related controller code and whatnot. I followed it some when working on #906

@jasonaowen replied:

Yeah, this is an easy sweater to unravel! It also has lots of loose threads. We should delete all that unused code, but let's be careful to do so incrementally.