SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 20 forks source link

Make DSLTester inner class static #973

Closed jasonaowen closed 6 years ago

jasonaowen commented 6 years ago

SpotBugs recommended:

Should be a static inner class

This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.

Make the inner class static, as SpotBugs suggests.

I tested this by running DSLTester.main() and briefly comparing its output before and after the change.

Issue #915 Use static analysis to find bugs