Closed frankduncan closed 6 years ago
Thanks for the review @PaulMorris ! I did some discussion inline before I make some of the changes you were requesting. I'm also requesting a quick review from @jasonaowen as a secondary sanity check.
Per discussion on zulip, I've added some commits for the CSS part. I'm +1 to merge pending @jasonaowen taking a look.
@frankduncan this is pretty amazing! Awesome job.
In particular, I like the logic around disabling deletion if there are existing enrollments with that provider type or if there are provider type settings.
Is there a way to add organizational provider types, or only individual?
There is, I think, follow-up work to fully complete the feature of "adding and editing provider types", but this PR is probably enough to resolve #41. Can you help me figure out the remaining steps necessary, and then we can open issues?
I've opened #1060, #1061, and #1062 for these issues. Yay!
This grew to more than just #41, as it appeared the entire provider type editing UI was incomplete.
Test by adding, editing, and deleting provider types from the admin interface. Additional check to see if agreements and license options are added to enrollments.