SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 20 forks source link

Fix 41: Create/Delete Provider Types #983

Closed frankduncan closed 6 years ago

frankduncan commented 6 years ago

This grew to more than just #41, as it appeared the entire provider type editing UI was incomplete.

Test by adding, editing, and deleting provider types from the admin interface. Additional check to see if agreements and license options are added to enrollments.

frankduncan commented 6 years ago

Thanks for the review @PaulMorris ! I did some discussion inline before I make some of the changes you were requesting. I'm also requesting a quick review from @jasonaowen as a secondary sanity check.

PaulMorris commented 6 years ago

Per discussion on zulip, I've added some commits for the CSS part. I'm +1 to merge pending @jasonaowen taking a look.

jasonaowen commented 6 years ago

@frankduncan this is pretty amazing! Awesome job.

screenshot 2018-08-24 15 32 22

In particular, I like the logic around disabling deletion if there are existing enrollments with that provider type or if there are provider type settings.

Is there a way to add organizational provider types, or only individual?

There is, I think, follow-up work to fully complete the feature of "adding and editing provider types", but this PR is probably enough to resolve #41. Can you help me figure out the remaining steps necessary, and then we can open issues?

frankduncan commented 6 years ago

I've opened #1060, #1061, and #1062 for these issues. Yay!