search

SolutionGuidance / psm

Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal
http://projectpsm.org/
Other
26 stars 20 forks source link

842 fix show error on personal email address #987

Closed lorinpa closed 6 years ago

lorinpa commented 6 years ago

On both the 'Register New' and the edit existing enrollment application pages (for individual providers), > personal info tab. Display the 'Personal Email Address' input field as required when the 'Same as Above' input field is checked.

This pull request also adds serenity tests verifying the 'Personal Email Address' required attribute displays as expected. This pull request tests the 'Personal Email Address is required when same as above is checked.' error message displays as expected.

Issue #842 Show error on personal email address

jasonaowen commented 6 years ago

Jenkins, test this please.

lorinpa commented 6 years ago

Hi Jason @jasonaowen and Paul @PaulMorris , Thank you for the review. I made the changes you requested. Please let me know if this pull request is OK.

PaulMorris commented 6 years ago

Jenkins, test this please.

PaulMorris commented 6 years ago

Thanks @lorinpa ! The changes look good, and I did a build and everything worked as expected. So I'm +1 to merge this PR.

One thing I noticed that would be good to do in a follow-up is that checking "same as above" now toggles one required asterisk on/off, but the two that are below "same as above" do not toggle on/off. So you have fields that stay marked as required that aren't actually required (when "same as above" is checked). We should toggle all of these asterisks for consistency.