search

Solutions-Nitriques / anti_brute_force

Secure your Symphony CMS login page against brute force attacks
http://symphonyextensions.com/extensions/anti_brute_force/
Other
10 stars 12 forks source link

ASDC dependency #2

Closed nickdunn closed 13 years ago

nickdunn commented 13 years ago

I think you can remove this dependency and call the database with Symphony::Database. ASDC doesn't really add anything extra except returning objects rather than arrays, so I'm not sure you'll see any benefit. Besides, ASDC is no longer maintained and is likely to be deprecated in the future anyway :-)

nitriques commented 13 years ago

I used ASDC since it had a pretty clever Iterator pattern in it. Since I like engineering, this seemed appealing to me. BUT, since it me be obsolete in a near future, I think you are probably right: I should remove this and used the default connector.

It may seems weird but I never used Symphony::Database. Does it provides the same king of methods (query, select, update, insert, escape, delete ?)

nitriques commented 13 years ago

@nickdunn: Turns out it was really easy to change from one to another :) I won't use it no more !

nitriques commented 13 years ago

@nickdunn: Check issue #3 if you will :) I report it myself