search

Solutions-Nitriques / anti_brute_force

Secure your Symphony CMS login page against brute force attacks
http://symphonyextensions.com/extensions/anti_brute_force/
Other
10 stars 12 forks source link

Inconsistent spelling of the word "grey" ("gray")—menu item broken #25

Closed michael-e closed 10 years ago

michael-e commented 10 years ago

The inconsistent spelling of the word "grey" (or "gray")—English vs. American spelling— is the reason for at least one bug: The menu item "Gray listed IPs" doesn't work, because the value of the GET param is "grey" instead of "gray".

Shouldn't be too hard to fix.

michael-e commented 10 years ago

I forgot: I suggest to make the naming consistent throughout the extension, but really, I don't care which version wins. :-)

(It would be less work to switch to "gray" everywhere.)

nitriques commented 10 years ago

Man, I live in Québec, Canada, so at school, we learn both (best way to mess my head up). Symphony uses a lot of European (hence British) words, but my heart is with the Americans for spelling. I will have to do research on which to use.

michael-e commented 10 years ago

Haha, nice. As I already said, switching to "gray" would be easier, because you used this spelling most of the time.

nitriques commented 10 years ago

"gray" it will be. I now I will remember it, since Americain starts with an A and English (which mean British for me as I speak French) starts with an E. Mind blown.

I will do it tomorrow a proper text editor (not vi, which I am using on my old Macbook 2007/OS X 10.5.8 right now).

nitriques commented 10 years ago

Note to self: I should check color vs. colour while at it...