search

Solutions-Nitriques / oembed_field

Easily embed videos/images from ANY website that implements the oEmbed format
http://symphonyextensions.com/Solutions-Nitriques/oembed_field/
Other
7 stars 11 forks source link

2.3dev #25

Closed andrewminton closed 12 years ago

andrewminton commented 12 years ago

Here goes a pull request... I got it to request dev2.3 instead of master.. confusing layout for the switching of branches for pull requests me thinks!

Anyways, let me know if this is all good for you!

Cheers

Andrew

nitriques commented 12 years ago

@andrewminton Thanks mate for this !!! I really apreciate it !

But I don't feel well about removing the name of the contributor of each drivers.. Maybe we could add their names in the meta.xml file ?

andrewminton commented 12 years ago

Yes, Good point @nitriques. Add contributors to the meta.xml file is best. I was just following the extension migration guide and it was best practice to remove the about() function.

andrewminton commented 12 years ago

Hey @nitriques , Shall I pull in driver contributors into meta.xml and send a fresh pull request?

nitriques commented 12 years ago

Yes Please !

I have started a new project usign Sym 2.3 but did not require this extension, so I did not bother doing it. Sorry.

Could you update to @rowan-lewis pullrequest too ?

andrewminton commented 12 years ago

I shall merge Rowans commits into mine and send fresh pull to you over weekend hopefully.

nitriques commented 12 years ago

Super thank you very much Andrew.

andrewminton commented 12 years ago

Ok so @nitriques I've added @rowan-lewis changes and updated meta XML, I also found SlideShare oembed data and made a driver for that as it was fairly easy to build.. check all code and update as you see fit. cheers Andrew!