search

Solutions-Nitriques / oembed_field

Easily embed videos/images from ANY website that implements the oEmbed format
http://symphonyextensions.com/Solutions-Nitriques/oembed_field/
Other
7 stars 11 forks source link

fixed typo on class name and changed it to serviceEmbedly; also found ou... #38

Closed bzerangue closed 11 years ago

bzerangue commented 11 years ago

FIXED typo on class name and changed it to serviceEmbedly; also found out that you have to list urls of service you use, since it oembed service and has service providers, so you have list the service providers in this file.

nitriques commented 11 years ago

Wooo man you're too fast! I just made a simple copy of the Twitter driver without testing anything.

But thanks to you, it's now clear that we have a problem: Embed.ly will now conflict with "native" driver since they will be able to handle all of their supported service. Driver detection is made based on the url given. This really is a pain in the ass.

I do not know how we will manage this... Any ideas ?

bzerangue commented 11 years ago

Two different ways...

  1. I will contact Embed.ly and see if they can send me an exhaustive list of all their available services in a comma delimited list, and then we can pull that list into the Embed.ly driver file.
  2. Or, maybe there could be an Embed.ly API field that is available in the System/Preferences... where you can enter your API Key as well as the user listing the Providers they want to include, and the users will have to include their providers that they want available to use with Embed.ly.

On Fri, Sep 6, 2013 at 12:36 AM, Nicolas Brassard notifications@github.comwrote:

Wooo man you too fast! I just made a simple copy of the Twitter driver without testing anything.

But thanks to you, it's now clear that we have a problem: Embed.ly will now conflict with "native" driver since they will be able to handle all of their supported service. Driver detection is made based on the url given. This really is a pain in the ass.

I do not know how we will manage this... Any ideas ?

— Reply to this email directly or view it on GitHubhttps://github.com/Solutions-Nitriques/oembed_field/pull/38#issuecomment-23919848 .

nitriques commented 11 years ago

Hummm, I am not quite sure I like your ideas...

  1. Maintaining that list would be aweful.
  2. This is better, but It still does not fully solve the problem with the driver conflict.

You see the drivers are tested in asc order given by this call https://github.com/Solutions-Nitriques/oembed_field/blob/master/lib/class.serviceDispatcher.php#L41

This did not cause troubles before, but it is now. I think I will add a priority property on the drivers. We could than sort them with that, and be able to wilcard embed.ly.

bzerangue commented 11 years ago

Actually, they maintain the list in their SERVICE API, http://embed.ly/docs/endpoints/1/service

Is there a way to pull in that list? that way it will always keep that populated...

On Fri, Sep 6, 2013 at 2:58 PM, Nicolas Brassard notifications@github.comwrote:

Hummm, I am not quite sure I like your ideas...

  1. Maintaining that list would be aweful.
  2. This is better, but It still does not fully solve the problem with the driver conflict.

You see the drivers are tested in asc order given by this call https://github.com/Solutions-Nitriques/oembed_field/blob/master/lib/class.serviceDispatcher.php#L41

This did not cause troubles before, but it is now. I think I will add a priority property on the drivers. We could than sort them with that, and be able to wilcard embed.ly.

— Reply to this email directly or view it on GitHubhttps://github.com/Solutions-Nitriques/oembed_field/pull/38#issuecomment-23965286 .

nitriques commented 11 years ago

@bzerangue This should be fixed in the 1.7 release I am about to create! Thanks for your help.