search

Solutions-Nitriques / oembed_field

Easily embed videos/images from ANY website that implements the oEmbed format
http://symphonyextensions.com/Solutions-Nitriques/oembed_field/
Other
7 stars 11 forks source link

Hows that? #8

Closed andrewminton closed 13 years ago

andrewminton commented 13 years ago

This is the first time I've done pull request so I'm learning as I do them.

nitriques commented 13 years ago

Wow ! Great! Merged !

nitriques commented 13 years ago

First time is always difficult! I had to do it 3 times as well when I push things to the datetime_field extension!

nitriques commented 13 years ago

Hey Andrew, I reviewed your code and it seems that there are some code needed for Youtube, that may not work with other providers...

This part if (strpos($params['url'], '#') !== FALSE) { // split on every # or / $exploded = preg_split('/[\/#]/', $url); $url = self::BASE_URL . $exploded[count($exploded)-1]; `}

was designed only for youtube and may not be right for other services... I'll updated my comments into the Youtube driver so copying it would be more accessible