search

Soluto / helm-charts

Soluto's Helm Charts Repository
MIT License
8 stars 12 forks source link

Allow pod annotations to be customized #18

Closed stefansedich closed 5 years ago

stefansedich commented 5 years ago

Current you are unable to set pod annotations with the helm chart, this would be handy so I can assign my IAM roles to them for kube2iam to work.

omerlh commented 5 years ago

Can you push another commit? I enable CI to run tests on forks.

stefansedich commented 5 years ago

Done @omerlh

omerlh commented 5 years ago

Thanks! Now tests are actually running, please take a look on the failed tests :)

stefansedich commented 5 years ago

Got it! looks like it just wanted a version bump.

omerlh commented 5 years ago

Thanks again!

stefansedich commented 5 years ago

@omerlh when can I expect the new chart to actually get released?

omerlh commented 5 years ago

A few minutes, when the CI run will be completed.

BTW if you have any feedback on Kamus - I'll be happy to hear :)

stefansedich commented 5 years ago

Awesome! I will let you know, getting the role on the pods was what was hanging me up from using it so once that is out we can get going.