search

Soluto / shisell-js

A service agnostic library for building immutable scoped analytic event dispatchers with extra data, identities and lazy filters.
MIT License
41 stars 3 forks source link

Create a build with bundling and minification #24

Open motiazu opened 7 years ago

Yshayy commented 7 years ago

Can be part of moving to Typescript #23

omerlh commented 7 years ago

Also publish to NPM

motiazu commented 7 years ago

I think typescript should be separate, but it should be connected to the same CI obviously

AvivRubys commented 7 years ago

Anyone know anything about JS bundling? I started playing around with rollup for this, and I'm not sure which bundles we need to create. If I understand correctly, we need bundles for:

  1. NodeJS - CommonJS
  2. Webpack 1 - CommonJS
  3. Webpack 2/Rollup - ES Modules
  4. Browser Globals

So if I understand correctly, options 1 2 & 4 can be served with one UMD bundle, and we need another ES bundle on top of that.

motiazu commented 7 years ago

So I talked to Aviv, realized we need to figure what outputs other libs are using and see what fits here since we're not sure the umd&es is exactly what we need to be exporting. So not closing this yet.