When refactoring pull sync subscription class to have shared base abstract code in common with the push subscription, the push sync subscription class was copied to the abstract class, but was not changed to inherit from it. This caused calls to sub.GetConsumerInfo to fail, since it didn't properly have the consumer name.
This affects all Push subscriptions if the dev calls sub.GetConsumerInfo, thankfully that's fairly uncommon. But...KeyValue watches use push under the covers and immediately call sub.GetConsumerInfo, so immediately fails.
Thanks @jlumsden-mts for reporting the issue with a repeatable test case.
1.0.6 Simplification Beta Update
Simplification
Renamed consume to Consume
Added Nats-By-Example Simplification Migration Example
1.0.5 Simplification Beta
Core
... (truncated)
Commits
c91ec41 Service / Simplification Documentation and Release Prep (#809)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps NATS.Client from 0.12.0 to 1.0.8.
Release notes
Sourced from NATS.Client's releases.
... (truncated)
Commits
c91ec41
Service / Simplification Documentation and Release Prep (#809)607e4c9
Fix use of JsOptions timeout (#808)020ea14
Simplification state, better thread safety (#807)dbcdfe2
Iterable Consumer Example fix (#806)46bd533
Custom TCP Connection interface (#767)549e191
Simplified Ordered Consumer (#802)a34cc81
Jwt Utils (#803)4f2c00a
Simplification Queue Example (#801)06cdeab
Added and updated Samples (#800)5f64a92
Start 1.0.8 (#798)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show