search

Solvik / netbox-agent

Netbox agent to run on your infrastructure's servers
Apache License 2.0
305 stars 77 forks source link

Gracefully handle neighbor-less LLDP devices #309

Closed ribetm closed 1 month ago

ribetm commented 1 month ago

lldpd may be successful but empty

c0ff3e commented 1 month ago

vill not #292 do the same ?

ribetm commented 1 month ago

vill not #292 do the same ?

You could say both have similar intents, but #292 is about lshw while mine is about lldpd.

Also, one notable difference is that #292 uses placeholders while mine simply does nothing if there are no visible neighbors

It's actually closer to this https://github.com/Solvik/netbox-agent/pull/279/commits/eb0a3a596fb6fc2ab13dc1dea1854189ed64f849 (from #279) but I prefer my solution since it allows us to support LLDP-compatible virtual switchs like OVS

c0ff3e commented 1 month ago

Sorry mixed it up, problem with working with 5 things simultaneously.