search

Solvro / backend-topwr

GNU Affero General Public License v3.0
11 stars 0 forks source link

chore/departments schema #21

Open czaja307 opened 4 days ago

Mikuu-252 commented 2 days ago

Image Departments_2024-11-20T18_13_59.445Z.ddb.json

Schema model idea for departments.

czaja307 commented 2 days ago

@simon-the-shark take a look from the mobile side

simon-the-shark commented 2 days ago

  1. We generally want one social link type enum for everything, departments, contributors and sci clubs (look at coributors final solution, @czaja307 you prolly need to coordinate)

  2. I have to check how we format the address in the departments, but I assume it could be helpfull to split address into 2 or 3 lines (not sure about the format) - similar to the solution we have in buildings

  3. Colors are hex repr so it should be varchar, not a text

czaja307 commented 2 days ago

my thoughts:

  1. can one field be in 2 different departments? (genuinely i have no idea about this, but i don't think so)
  2. i'm not sure what you meant by is_long_cycle - i suppose the difference between 6 and 7 semester studies, if so then i'd go with number value
  3. the extended version of fields_of_studies look really nice and will proly be useful in the future (have you though where you can get the data from, just asking)
  4. the rest of them are covered by Simon

overall, that's a piece of solid work 💪

Mikuu-252 commented 2 days ago

@simon-the-shark ad 1. When all schemas are ready, we can check which use links and create one table with links to all the other tables. ad 2,3. Okay, changed.

@czaja307 ad. 1. different departments But field can have 1 department but 1 department can have many fields. Or maybe I think wrong? ad. 2. Its diffrents betwen 3,5 years and 6 years fields. In pwr only medicine have it. https://rekrutacja.pwr.edu.pl/wyszukiwarka-kierunkow-studiow/lekarski/

czaja307 commented 2 days ago

ad. 1. makes sense now - cardinalities in both relationships are inverted (i didn't catch the one connected to links) ad. 2. go with the numeric value, because we also have for example 3 year studies like https://rekrutacja.pwr.edu.pl/wyszukiwarka-kierunkow-studiow/zarzadzanie/

Mikuu-252 commented 1 day ago

@czaja307 ad 1,2 Changed.

czaja307 commented 1 day ago

it may be nitpicking, but i'd change length to something like duration or semester_count to be more meaningful