search

Solybum / PSOBBMod-Addons

GNU General Public License v3.0
29 stars 29 forks source link

Update to display the correct HP values for De Rol Le and Barba Ray #12

Closed StephenCWills closed 7 years ago

StephenCWills commented 7 years ago

I hardcoded the HP lookups for De Rol Le and Barba Ray as special cases since I don't know if there's a more generic way to handle it. I couldn't find the max HP for the skull or the shells so I'm just setting max HP equal to HP in those cases, which works okay since the progress bar also displays numbers. I tested this against Normal/Online/De Rol Le, Normal/Online/Barba Ray, Normal/Offline/De Rol Le, Hard/Online/De Rol Le, and Ultimate/Online/Dal Ra Lie so I expect it to work for the full gamut.

Solybum commented 7 years ago

Sorry, I was already working on that and I don't like the idea of having the shell's bar always full.

StephenCWills commented 7 years ago

No, it's fine. I totally agree that it would be ideal to have the max HP of the shells, but I really only needed the body's HP for the kill counter. I figured I'd just put in a little extra effort to see if I could save you some work so I feel I should apologize if you had to duplicate some of that effort after all. Thanks for having a look at this.