search

Solybum / PSOBBMod-Addons

GNU General Public License v3.0
29 stars 29 forks source link

Added hide when in menu/shortcut/unavalible to Floor and mag #53

Closed Derfliest closed 2 years ago

Solybum commented 2 years ago

Something's wrong here. The files you are committing are in the root of the repo, and there should not be any addon files there.

Can you look into that?

Solybum commented 2 years ago

Can you remove the files in the root (they are still present in the PR it seems. image

Derfliest commented 2 years ago

yes ill see if i can fix it

Derfliest commented 2 years ago

It should be fixed now lol

Derfliest commented 2 years ago

hey i dont know how to do it cause im new to github but i was only trying to commit the two lua in item reader for you to check out. i dont know how to remove commits. I was messing with the player reader to try to get the HP bar to have the same functionality but was unsuccessful. I will keep trying though. so i wasnt trying to commit 9 things.

Solybum commented 2 years ago

While it is possible to "revert" commits, I'd suggest to think of it as "correcting changes".

In the original case, since you had some files in the root of the repository that belonged to an addon folder, you'd just delete the file in the root, while keeping a copy of the content to paste into the actual addon file.

Also I assume you saw the issue of content being copy pasted like 3 times in the same addon file which obviously is a big issue as that might actually break the addon.

If you'd rather not have all these commits, the best option would be to close the PR without merging, making a new one based on a different branch (out of the commit you started originally) and modifying the files again. Actually, I can do this when merging the PR, although in that case it would only affect my own repo and not yours.

Solybum commented 2 years ago

Any chance you can contact me on Discord @ Soly#0637 ?