search

Solybum / PSOBBMod-Addons

GNU General Public License v3.0
29 stars 29 forks source link

Check for monster death is incorrect #80

Closed Daggerfall-is-the-best-TES-game closed 1 month ago

Daggerfall-is-the-best-TES-game commented 2 months ago

According to Ender, there is a way for monsters to be marked as dead which is not the same as having 0 hp because monsters that are helled quick enough on spawn can die on full hp. And this causes dead enemy hp bars to stick around.

https://discord.com/channels/313866173370335232/313866173370335232/1174844471519744030

Elixir70 commented 1 month ago

Should be fixed by a66a5d4eeb0b2e6e9105339edad56a33411533ce

Daggerfall-is-the-best-TES-game commented 1 month ago

nice! I wonder if the HP checks are necessary now that we check this death flag?

Elixir70 commented 1 month ago

Uh maybe, but I would just leave them. It means the bosses with HP gates can potentially disappear from the Monster Reader for a frame, but there are some 'control' entities for some enemies that have 0 HP and could show up if that check was removed (like Slimes and Vol Opt form 1 control).

Daggerfall-is-the-best-TES-game commented 1 month ago

ok, it's good to keep it in for the edge cases like that

Daggerfall-is-the-best-TES-game commented 1 month ago

I haven't tested it, but I will close it now and just reopen the issue if it's not working. But I assume you fixed it, so great job!

Daggerfall-is-the-best-TES-game commented 1 month ago

image uhh, it might be showing the entire enemy spawnset before they're spawned lol.

Elixir70 commented 1 month ago

Isn't that multimode free field temple (or one of the govt quests)?

That map spawns a lot of enemies on all 3 routes from the start. It looks like you went to the left side first?

Or is it possible your Monster Reader used to be set to "Show current room only" and it no longer is?

Daggerfall-is-the-best-TES-game commented 1 month ago

if by free field you mean just going into the temple warp, yes, it is , there are indeed 3 routes, and I did go to the left. it seems to be fine for other areas. And I did indeed not have current room checked. That explains it.