Fix `plotPDFlist()` and `plotCDFlist()` so that they can plot arbitrary length vectors

SomaLogic / SomaPlotr

A highly specialized suite of standardized plotting routines based on the "Grammar of Graphics" framework of mapping variables to aesthetics used in 'ggplot2'. Graphics types are biased towards visualizing SomaScan (proteomic) data.

https://somalogic.github.io/SomaPlotr/

Other

3 stars 3 forks source link

Fix `plotPDFlist()` and `plotCDFlist()` so that they can plot arbitrary length vectors #7

Closed stufield closed 11 months ago

stufield commented 12 months ago

currently they must be the same size (length)
this shouldn't be necessary; but because they are converted into a data.frame prior to plotting, R chokes
data frame is part of pipeline into plotPDFbyGroup(), which must be a data frame
this bug is diabolical because for small lengths, the bug disappears and elements are recycled as necessary! Which is absolutely the wrong thing to do!

stufield commented 12 months ago

The fix should be something like this:

 lapply(.data, "length<-", max(lengths(.data))) |>  # fix for jagged elements
    data.frame(check.names = FALSE) |>
    gather(key = !!label) |>
    drop_na(value) |>
    plotCDFbyGroup(apt = "value", group.var = !!label, main = main, ...)