Closed christophhagen closed 1 year ago
@SomeRandomiOSDev what's it going to take to get this PR accepted? The failed "@codacy-production
Codacy Static Code Analysis" gives no clues. Oh, @christophhagen, I see the answer is easy: bring back Package.resolved, but use the one generated on your machine after you swift package resolve
, that no longer mentions Half. Checking it in is best practice anyway.
With these changes, the library passes all tests on Windows and I would submit CI actions to test there.
Argh, for my purposes this is not a fully-complete solution because Float16
is apparently only available on Apple Silicon (seriously, Apple?)
I wonder if support for CBOR serializing 16-bit floats really needs to be built into the core of this library, or if it could be added as an extension the way we normally would with any user-defined types?
@christophhagen I took a first cut at making it work on x64 macs, but it's clear that some of the old logic needs to be restored because the build is failing. The CI job passes for some reason, which also needs to be corrected in the workflow file.
@christophhagen OK, fixing it for x64 macs was easy: https://github.com/christophhagen/CBORCoding/pull/1
@christophhagen And here is the PR that ensures failures in CI are actually reported.
@christophhagen I created a release to address a lot of the issues that came up due to this repo being so out of date. Please rebase on this release and update this PR accordingly
Closing the PR due to #27.
Description
This PR removes the dependency on
Half
, which is currently used to provide a half-precision floating point type.Float16
was introduced with Swift 5.3, so the dependency is no longer needed.Checklist
Ensure that your
pull request
has followed all the steps below:Proposed changes
The main changes are:
Float16
type insteadMinor changes are:
if-else
statementsAdditional Info
The dependency on
Float16
requires higher minimum deployment targets on all platforms:9.0
->14.0
10.10
->11.0
9.0
->14.0
2.0
->7.0
For systems with swift version lower than
5.3
, the dependency on Half is still needed. In this case thetypealias Float16 = Half
is included. The package descriptions for4.2
and5.0
still include the dependency. The correct compilation on older platforms is untested.