Make sure failures in multiline CI steps are not swallowed. - Githubissues

SomeRandomiOSDev / CBORCoding

Easy CBOR encoding and decoding for iOS, macOS, tvOS and watchOS.

MIT License

49 stars 14 forks source link

Make sure failures in multiline CI steps are not swallowed. #24

Closed dabrahams closed 1 year ago

dabrahams commented 1 year ago

Description

Cause failures in CI to be reported

Checklist

Ensure that your pull request has followed all the steps below:

[x] Code compilation.
[x] All tests passing.
[x] No new SwiftLint issues.
[x] Added new unit tests, if applicable.
[x] Extended the documentation (including README), if applicable.
[x] Updated version in CBORCoding.podspec following semver guidelines.
[x] Ran workflowtests.sh and passed.
[x] Added myself to the CONTRIBUTORS file.

Proposed changes

Without this change, it is possible to have a passing CI job even though the build failed, e.g.

https://github.com/dabrahams/CBORCoding/actions/runs/6806944368/job/18509010389#step:4:99

And in fact you will see that this PR reveals 1 linting problem and 11 test failures on ubuntu-latest that were being ignored.