search

Someone-Else-Was-Taken / BetterEndForge-Reforked

Other
4 stars 6 forks source link

Array hashCode() is causing issues #58

Open Quarris opened 1 year ago

Quarris commented 1 year ago

While messing with configs and mixins for a modpack, I came across this issue where the configs wouldn't get the proper entry because the Json Key hashCode is not correctly implemented.

The array hashCode() should be gotten from Arrays.hashCode(this.path) instead of the direct hashcode function to get the proper result of having the same value returned each time.

https://github.com/Someone-Else-Was-Taken/BetterEndForge-Reforked/blob/28a4e60e83c697d52486267fc3535020ae0d53b6/src/main/java/mod/beethoven92/betterendforge/config/jsons/JsonConfigKey.java#L44

MagmaBro123 commented 1 year ago

This mod is dead. Don't bother opening issues here.