Someone-Else-Was-Taken / BetterNether-Reforged

BetterNether Mod Ported to Forge
GNU General Public License v3.0
8 stars 3 forks source link

Oh The Biomes You'll Go biomes do not allow to generate the biomes of this mod. #62

Open Doming3000 opened 2 years ago

Doming3000 commented 2 years ago

Hello, I play this mod together with another called "Oh The Biomes You'll Go", what happens is that biomes are not being generated, but structures, minerals, and little else, but nothing about biomes, not even with the /locatebiome command I can find it, I'm 100% sure it's a bug.

Toma400 commented 2 years ago

It allows, but you need to add BetterNether biomes to BYG configs. By default, BYG "controls" biomes of End/Nether, therefore needs either manual adding of new biomes, or integration. BYG-BetterEnd had its integration, but BetterNether port is new thing, so there's no integration - meaning, you need to manually add the biomes.

If you want, I can give you my config (including BYG, Infernal Expansion and BN biomes - if you do not use IE, use config with "excl_ie" part, but remove that additional part in the name, so it will be called "byg-nether-biomes" only): byg.zip

Toma400 commented 2 years ago

But definitely +1 for taking this topic, hopefully SomeoneElseWasTaken adds that integration for this mod too, since it is not that obvious for people to understand configs

Doming3000 commented 2 years ago

It allows, but you need to add BetterNether biomes to BYG configs. By default, BYG "controls" biomes of End/Nether, therefore needs either manual adding of new biomes, or integration. BYG-BetterEnd had its integration, but BetterNether port is new thing, so there's no integration - meaning, you need to manually add the biomes.

If you want, I can give you my config (including BYG, Infernal Expansion and BN biomes - if you do not use IE, use config with "excl_ie" part, but remove that additional part in the name, so it will be called "byg-nether-biomes" only): byg.zip

My happiness did not last at all, I put that file and after restarting my game along with deleting the DIM -1 folder I am still having problems with half of the biomes in my game, I would hate to have to throw another advanced world in the trash just because two mods can't get along.

Toma400 commented 2 years ago

Hopefully this will get author's attention then. Does it mess Overworld generation too, or just Nether one, as you described above? Also, deleting dimension folders is the last step I'd take in that case. Backuping is great idea too if you are adding mods to it, always make backup before that.

Doming3000 commented 2 years ago

Thanks for the advice about the backups, normally I only do them if I am going to change the version or play with the data of the level.dat, regarding the dimensions this only happens to me with the Nether, I do not have more mods that affect the over and in for the end "Better End" it's not a problem, but if I get quite depressed not having full access to the Nether, of course I can take some things from the creative but it breaks the experience a bit, if you know what I mean.

Toma400 commented 2 years ago

Well, I'd suggest making them once in a while, and especially once adding new mods. For saves I love I do it almost each time I play, but I can understand if that seems like too much :P As for the world you have with BN/BYG issue, maybe I could try to help via playing it and finding out changes? If you want to send me save/modpack and let me tweak things to see if it's fixable, you can dm me on Discord (Toma400#9987)

OnesAndZer0s commented 2 years ago

Ive been digging in the .dat file, and it seems that, even if you change the nether generation to "byg:bygnether" as the FAQ states, that this mod overwrites it no matter what. There is no config option for this, and this causes the issue that is being described. This doesnt apply to "Better End" because there is a config to turn off the generation, and let BYG handle it

Toma400 commented 2 years ago

It sounds weird to me, because no matter the modpack I've made, none had any issues with BYG/BN biome management, after altering the config...

Toma400 commented 2 years ago

Also, that last comment from the same issue is very interesting, may explain a bit why I haven't encountered the issue (yet): https://github.com/Someone-Else-Was-Taken/BetterNether-Reforged/issues/54#issuecomment-1040410059

Toma400 commented 2 years ago

I may have found temporary solution for this, but @Someone-Else-Was-Taken should take a look at it to improve compatibility, since switching that should be in core files:

  1. Explore you save file via NBTExplorer
  2. Head to level.dat > Data > WorldGenSettings > dimensions > minecraft:the_nether > generator > biome_source
  3. Change your "type" from "betternether:nether_biome_source" into "byg:bygnether".

Remember to do it on copy of your world, since I can't promise you won't corrupt your save with such action! (as generally working on NBT data is dangerous)

lSherozl commented 2 years ago

I do not know what any of you are going on about, BYG biomes and better nether biomes still spawn, if you have biomes o plenty as well, you just have to set BOP nether to false, it will use the default nether of BYG, which will spawn all biomes....THE ISSUE is vanilla biomes will stop spawning

Doming3000 commented 2 years ago

Well, how curious, because I experienced several problems, first the biomes were not generated, after playing for a while with the Level.Dat only some were generated and they were ridiculously extensive, then they were generated but without blocks, looking like "Nether Wastes" from version 1.15, if I didn't want to play quietly in my survival world this would be funny, I just hope my colleague can help me through Discord and that no one else has to go through this, I'll attach some screenshots that I think may be useful: 2022-03-22_10 04 35 2022-03-22_10 30 34

lSherozl commented 2 years ago

Spawns fine for me, vanilla biomes are what don't spawn image

Doming3000 commented 2 years ago

Congratulations, I guess, well, I just want this to be fixed sooner or later.

lSherozl commented 2 years ago

Well the owner of the mod has literally not responded for months, so good luck trying to get him to fix your issues, when the basics of vanilla biomes not spawning have not been fixed

Doming3000 commented 2 years ago

I leave here the link of my curseforge profile so that anyone who wants can download it and see what happens with this. Notice that it is a copy from days ago and probably stayed at the point where biomes were not generated: https://www.dropbox.com/s/wsemh7kmv22t9ub/Modpack%20Survival%201.16.5.zip?dl=0

lSherozl commented 2 years ago

What is your worldtype

Doming3000 commented 2 years ago

Sorry, I do not understand the question well, my knowledge of English is quite limited, if by type of world you mean what I think, it is a normal world, generated directly after clicking the "Create new world" button

lSherozl commented 2 years ago

Make sure your WORLDTYPE is default....and then all nether biomes should spawn, if u also have biomes o plenty, then u need to turn bop to false

lSherozl commented 2 years ago

There is nothing to solve, just set your world type to default

276044868_360205705839659_6784317012442982841_n

Doming3000 commented 2 years ago

Can you give me the route in NBT Explorer?

lSherozl commented 2 years ago

275694221_1223566911517044_2704438006517316446_n

Doming3000 commented 2 years ago

I don't want to create another world, sorry but I refuse to trash a world because of a mod.

lSherozl commented 2 years ago

I dont remember if this can help but try changing this, just make a backup in case it crashes ur world image

lSherozl commented 2 years ago

Change the type of the overworld, mine is set to BOP overworld, because it lets u spawn all biomes if u have that.....check what yours is and change it to another and try, try default, if its already default try byg type

lSherozl commented 2 years ago

Try this https://github.com/AOCAWOL/BYG/wiki/Nether-&-End-Biomes-FAQ

Doming3000 commented 2 years ago

That last one is what causes the biomes to be generated but without blocks, the other guy told me about it on Discord

lSherozl commented 2 years ago

if nothing else works, especially the above steps, u may have no choice but to restart your world, you can use world edit and nbt to keep your stuff and builds and bring it back to ur new world, just copy the same seed, use NBT to copy ur stuff over to the new world, and use world edit to copy your builds

Doming3000 commented 2 years ago

I would happily do it but this is the second time this has happened to me, if I make a new world it will most likely be repeated again, if it continues I will have no choice but to delete everything and redo my modpack, without BetterNether

lSherozl commented 2 years ago

I reccomend creating a new world, and TESTING FIRST IN CREATIVE, if the world type you chose lets all the biomes spawn, including vanilla, if it does, then you can create a survival world with the same settings and finalize it

lSherozl commented 2 years ago

This mod is unfortunately very broken, and the owner has practically abandoned it

Doming3000 commented 2 years ago

Yuck, and since 1.12 I'm playing Better Nether, I guess I'll just give up if my last card doesn't work, which is to wait for me and my buddy to experiment with the profile and see what the damn file breaks. everything.

Doming3000 commented 2 years ago

Creating new worlds and experimenting is what I usually do very often, today I did it, lol, anyway, worst case, what other mods similar to BN do you know? that they are not so broken yes

lSherozl commented 2 years ago

There are a lot for the end and nether: https://www.curseforge.com/minecraft/mc-mods/endergetic https://www.curseforge.com/minecraft/mc-mods/biomes-o-plenty (If you add this, turn BOP nether to false in the config and all biomes of byg will still spawn, this mod is compatible with byg and adds nether biomes) https://www.curseforge.com/minecraft/mc-mods/farlanders https://www.curseforge.com/minecraft/mc-mods/nethers-delight https://www.curseforge.com/minecraft/mc-mods/infernal-expansion https://www.curseforge.com/minecraft/mc-mods/nethers-exoticism Just look here https://www.curseforge.com/minecraft/mc-mods/search?minecraft-mc-mods-page=2&search=nether#t1:mods

Doming3000 commented 2 years ago

Thank you, if I decide to give up I'll put it here and stop wasting your time because I'm sure you have better things to do

lSherozl commented 2 years ago

Yeah no problem

Toma400 commented 2 years ago

@SrXili I tried to help Doming3000 earlier and had no success, so not sure if it can be helpful. I had no issues with it, but I don't really know how it turned out correctly. Was it because world generator being set correctly, or use of Infernal Expansion, or just my luck? :_: But sure, you can dm me on Discord if you want, I will try my best to help

Doming3000 commented 2 years ago

Yes, I definitely decided to give up on this port, I don't know if some strange configuration in my profile caused such a stir or if it was just bad luck, I hope in the future this doesn't happen to anyone again, thank you very much to everyone who tried to help me.

Twely commented 2 years ago

i have a problem with biomes youll go nether configs and betternether reforged too

setting the weights for byg nether config to 0 will not make it so that the biome wont spawn in the nether. so i found out that i have to go to the world generation settings in NBTExplorer and change it to byg:bygnether and doing so made it so that the byg configs work which it did which is good. however doing that caused the betternether biomes to not spawn anymore

example: after setting priority to byg i then set sythian torrids to weight 0 and used locatebiome to check for it and it says cannot be found which is good. but in the process of setting the priority to byg it also removes better nether biomes cause the priority isn't set to better nether anymore. you can see that in one of the screenshots where it says nether_jungle cant be located

https://cdn.discordapp.com/attachments/636020573046308874/966205616945242142/unknown.png?size=4096 https://cdn.discordapp.com/attachments/636020573046308874/966205862916018186/unknown.png?size=4096 https://cdn.discordapp.com/attachments/636020573046308874/966205560678670347/unknown.png?size=4096 https://cdn.discordapp.com/attachments/636020573046308874/966205527422033930/unknown.png?size=4096

Is there a way to combine both byg and better nether world gen settings? or can you ONLY USE 1 priority for the biome generation??? is there a way to use byg and betternether priority at the same time?? cuz it literally shows it in the biome_source type that its using better nether and i changed it to byg:bygnether. is this impossible to fix?

Doming3000 commented 2 years ago

Based on my experience, it is impossible to fix

TheWitheredStriker commented 2 years ago

I've reached out to Someone-Else-Was-Taken on CurseForge itself (where they were last active in June) about the mod's many problems. They have yet to respond.

I'm a growing programmer and I plan to pick up Minecraft modding in the future. If SEWT either doesn't return, or does but no longer works on the mod, I'll eventually fork the repository and try to fix its issues myself. Someone has to do it.

I cannot guarantee success, but at least I'll try. I'm not yielding to Fabric, and not giving up on this mod without a fight.

Doming3000 commented 2 years ago

Good luck

TomatoPuddin commented 10 months ago

Fixed in https://github.com/TomatoPuddin/BetterNether-Reforged

TheWitheredStriker commented 10 months ago

Awesome! Thank you so much!