search

Someone-Else-Was-Taken / Periodic-Table-Reforged

A Collection of Unofficial ports of the CaffeineMC Mods alongside Iris.
GNU General Public License v3.0
45 stars 14 forks source link

Incompatible With 1.18.1 (Compatible with 1.18 only) #151

Open Entralia opened 2 years ago

Entralia commented 2 years ago

When attempting to launch the game in 1.18,1, crash states that the mod only works in 1.18

Kithron commented 2 years ago

I'm having the same issue as well saying this mod will only work for 1.18. Currently using 1.18.1.

souless44 commented 2 years ago

The issue is inside the mod itself. You have to unzip the file and go into the Meta folder and change the version range to 1.18.1 instead of just 1.18 Not sure why this hasn't been done yet but that is the fix. Sort of.

SzczurekYT commented 2 years ago

It's done but it's not released.

ShibeTemple commented 2 years ago

It's done but it's not released.

what do you mean by this?

SzczurekYT commented 2 years ago

It's done but it's not released.

what do you mean by this?

On github it's fixed, if you would build it from source then it would work, but on curseforge it isn't updated. But you even can't build it because it misses MagAPI. I don't know how to fix this

ShibeTemple commented 2 years ago

It's done but it's not released.

what do you mean by this?

On github it's fixed, if you would build it from source then it would work, but on curseforge it isn't updated. But you even can't build it because it misses MagAPI. I don't know how to fix this

Modifying the manifest allows for it to run on 1.18.1, however, there is an issue with block layering. Is this issue fixed or only the manifest? See #177 #168

SzczurekYT commented 2 years ago

It's done but it's not released.

what do you mean by this?

On github it's fixed, if you would build it from source then it would work, but on curseforge it isn't updated. But you even can't build it because it misses MagAPI. I don't know how to fix this

Modifying the manifest allows for it to run on 1.18.1, however, there is an issue with block layering. Is this issue fixed or only the manifest? See #177 #168

No it's still on 1.18.1 there are also bug reports about that on new Magnesium repo. https://github.com/Someone-Else-Was-Taken/Magnesium/issues/18 https://github.com/Someone-Else-Was-Taken/Magnesium/issues/5

I event thinked about trying to mess with the code myself but I can't due to https://github.com/Someone-Else-Was-Taken/Magnesium/issues/8 and I don't have any experiance with rendering and I'm pretty new to modding.

SzczurekYT commented 2 years ago

The worst thing is that these are pretty huge issues and Someone-Else-Was-Taken is inactive for around a month now.

ShibeTemple commented 2 years ago

The worst thing is that these are pretty huge issues and Someone-Else-Was-Taken is inactive for around a month now.

Haha. There is a funny thing. In my experience, setting up these development environments for Minecraft is more difficult than the actual programming. So many quirks with IntelliJ, Eclipse, Gradle. UGH. Same as with native Android development.

There is another fork named Rubidium https://github.com/Asek3/Rubidium. It is on 1.18.x and works decently well, however not as well as Magnesium yet. In my testing, it performs a bit worse but that is ok; the major issue with it in my experience is a bit of stuttering. I cannot comment on specifics about that as I am still testing and trying to find the root cause. However, it could prove useful to compare the two project repositories to see the differences. Maybe specifically analyze how the model/texture layers are dealt with.

Right now, Rubidium does not have connected textures, while magnesium had it albeit a bit finicky, however, mods like Connected Glass worked on Magnesium and don't work on Rubidium https://github.com/Asek3/Rubidium/issues/22. There are also other smaller issues worth looking into. While the developer is more active than Someone-Else-Was-Taken, they still aren't as active as the Twilight Forest or Distant Horizons team sadly and their plans with the project are unclear.

Very interested in making this work. Let me know if I can help in any way.