search

SomeoneElse37 / BattleBot

A Discord bot that rolls dice and stuff.
MIT License
0 stars 1 forks source link

/excel ignores secret characters #12

Open lenscas opened 7 years ago

lenscas commented 7 years ago

/excel doesn't check if the character is hidden or not. Because of this it shows their stats even if it should stay hidden.

SomeoneElse37 commented 7 years ago

Not a problem if /excel is GM-only (which I always assumed it would be, for precisely this reason).

lenscas commented 7 years ago

Why would /excel be GM only? The whole idea of it is to give players the ability to see the state of the RP in a nicer format then discord normally allows.

Maybe I can make the /excel command check if it is done by a gm or not and print hidden characters accordingly

SomeoneElse37 commented 7 years ago

I dunno- like I said, that was my assumption, and evidently it was not correct. This is also why I didn't accept your pull request into the master branch from the beginning- at the time, it would have given all players access to hidden data, which should not have been visible to them. Also because I have no way to open ODF spreadsheets, because I never installed OpenOffice because I bought MS Office because University required it.

One way to handle this would be to have /excel change its behavior depending on whether or not the person invoking it has GM permissions (i.e. either Administrator or Manage Messages).

Alternatively, you could have /excel never give out hidden info, and create an entirely separate GM-only command that will compile a spreadsheet with hidden info included and upload it to a PM. I think that's probably the better solution.