search

SomeoneElseOSM / SomeoneElse-style

An "England and Wales rural pedestrian" focused OSM-based map style. Example at https://map.atownsend.org.uk/maps/map/map.html . This is the tag preprocessing part of the style.
GNU General Public License v3.0
9 stars 3 forks source link

Render sink holes #11

Closed tommycrock closed 3 years ago

tommycrock commented 3 years ago

It would be nice if sinkholes rendered. Nodes perhaps as small grey circles, areas as a series of grey triangles pointing in to the centre. Perhaps different types should have different rendering but I'm not sure what. Thanks!

SomeoneElseOSM commented 3 years ago

I've made sinkholes that are mapped as ways render as cliffs, in https://github.com/SomeoneElseOSM/SomeoneElse-style/commit/b3dbf102d1170ab89129556018f782c4fd5e4f3a .

This won't deal with most of them, which are just mapped as nodes.

tommycrock commented 3 years ago

Thanks. I'm not sure if you've done it so they'll necessarily render the right way round? They're treated as areas in the wiki so won't have necessarily been drawn in one direction. At least there'll be a mark for now.

SomeoneElseOSM commented 3 years ago

They might indeed turn out the wrong way round, but there are relatively few of them in the UK and the ones that I checked on a test rendering (Derbyshire and Yorkshire) actually came out the right way around, purely by chance.

SomeoneElseOSM commented 3 years ago

The database is now reloaded and these are now visible.

tommycrock commented 3 years ago

Thanks very much. Should I open another issue for the nodes or do you not want to render them?

SomeoneElseOSM commented 3 years ago

No - nodes should be OK too:

Legend: https://map.atownsend.org.uk/maps/map/map.html#zoom=20&lat=-25.010959&lon=135.174165

In the Yorkshire Dales: https://map.atownsend.org.uk/maps/map/map.html#zoom=15&lat=54.17113&lon=-2.19609

tommycrock commented 3 years ago

Great, I see it. Thanks.