Open marwinburesch opened 4 years ago
Good morning!
Thanks for the feedback!
I would like to branch out into React, as that's a money maker here in the states (not sure about Germany, bit probably??).
I will try to rework the code for Js functional programing. I did that with the 'hover doodle' (etch-a-sketch) program and it was fun! When I do, I'll certainly let you know!
Applying for a back end job to get more experience right now, but front end UI is the rockstar of developing, yeah? Do you do back end?
Learning C# and it's messing with my JS Habits. They are very similar. Hope I don't lose understanding of UI programming with learning this.
Sidenote: picked up German lessons on Duolingo again to push myself to get the hell out of the air conditioned nightmare called, Amerika.
Talk to you soon!
On Mon, Jul 20, 2020, 12:06 marw notifications@github.com wrote:
Hi dude, had some time to look at your code :) I think it's a good approach and this calculator works very well. Smooth feeling UI 👌. There's some feedback and tips I'd like to give you on learning JS and other frontend/coding tech. Just some links and thought's in no particular order :) and without judgement of course.
- use more git conventions: here's a start https://www.freecodecamp.org/news/writing-good-commit-messages-a-practical-guide/
- use branches dude, branches rule, git is amazing a long, very technical lecture https://www.youtube.com/watch?v=yI0BtEzdGtw, interesting however
- I would recommend making that calculator without using OOP approaches, try making the whole thing with just functional programming. It probably sounds like a lot, but it's an excellent exercise to learn functional programming and paves the way for code splitting
- another good step might be a framework like Tailwind CSS https://tailwindcss.com/docs/installation or Bootstrap https://getbootstrap.com/docs/4.5/getting-started/introduction/ to overhaul the UI, they have great customizing options that are coupled with some other advanced subjects (npm or sass)
- once you got started with branches, send me the PR (just mention me with @ should work, or invite me to collaborate https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests )
- you can head over to lab.github.com and look for some courses, even the short ones about GitHub https://lab.github.com/githubtraining/first-day-on-github are quite awesome
Good stuff nonetheless cheers m 🐜
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SometimesTheFur/Calculator/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANNRQV7CF7RBC6QDEZQ5KVTR4RTQPANCNFSM4PCPZ5AQ .
Hi dude, had some time to look at your code :) I think it's a good approach and this calculator works very well. Smooth feeling UI 👌. There's some feedback and tips I'd like to give you on learning JS and other frontend/coding tech. Just some links and thought's in no particular order :) and without judgement of course.
npm
orsass
)Good stuff nonetheless cheers m 🐜