search

Sommerregen / grav-plugin-external-links

This plugin adds small icons to external and mailto links, informing users the link will take them to a new site or open their email client.
Other
16 stars 14 forks source link

[Enhancement] Customizable class for external links #14

Closed Swader closed 7 years ago

Swader commented 8 years ago

It would be good if there was an option to define a custom class for the external links. The reasoning is the langswitcher forcing the external class on the language links, which then makes the language links appear external, even if it is not so.

Of course, this problem can be bypassed by extending the plugin's partial and removing the forced external class, but it's more work for the end user, who seeks simplicity.

Sommerregen commented 8 years ago

@Swader Didn't noticed. I will consider your idea in the next release. Instead of exposing a class name, I really drop the support for that in the stylesheet L1. Is this an option you can live with?

Swader commented 8 years ago

I don't see any negatives right now, so sure.

Sommerregen commented 8 years ago

Sorry, to say something different, but today I thought about it. A class name external semantic and is something really special. It says that the link will be "external" or something like that and it doesn't make sense, that it is used in Langswitcher plugin. Clicking on a different language does not redirect you to any external site.

TLDR: Opening an issue on langswitcher plugin, because it should be addressed there and not here...

Sommerregen commented 7 years ago

Will close due to inactivity and wrong repo. Feel free to open it again.