search

Sommerregen / grav-plugin-external-links

This plugin adds small icons to external and mailto links, informing users the link will take them to a new site or open their email client.
Other
16 stars 14 forks source link

fix loading of a href element #24

Closed vavrecan closed 6 years ago

vavrecan commented 6 years ago

it can happen, that this function will fail in case of etc or or other issues. i would say it is a good idea to do additional error checking so that $a->getAttribute will not throw exception when a is null.

Sommerregen commented 6 years ago

@vavrecan Can you give me an example, when such a thing happens?

vavrecan commented 6 years ago

Iirc If tag in source is <abbr> </a> or so

Sommerregen commented 6 years ago

Merged. Thanks! :+1: