search

Sommerregen / grav-plugin-external-links

This plugin adds small icons to external and mailto links, informing users the link will take them to a new site or open their email client.
Other
16 stars 14 forks source link

FlexObjects compatibility: change references to `Page` class to use `PageInterface` #30

Open paulhibbitts opened 5 years ago

paulhibbitts commented 5 years ago

Hi @Sommerregen ,

I have started to use the newest Grav 1.7 Beta with Flex Objects, and have discovered a compatibility issue with External Links: https://github.com/trilbymedia/grav-plugin-flex-objects/issues/16

It looks like the fix for this is fairly minor issue to address (as Andy Miller just did for ShortCodes): https://github.com/getgrav/grav-plugin-shortcode-core/commit/c374d81db2e5c4d76ff994b9916ef106530ffc79

Might you please consider making this change in External Links? I'd be happy to test for you etc. This would then let all early users of Flex Pages use your Plugin🙂

Thanks very much, Paul

mahagr commented 5 years ago

Also, make sure the minimum Grav version is >=1.6 inside the blueprints.