search

Sommerregen / grav-plugin-external-links

This plugin adds small icons to external and mailto links, informing users the link will take them to a new site or open their email client.
Other
16 stars 14 forks source link

Image broken with CSS pipeline enabled #9

Closed seb-vial closed 8 years ago

seb-vial commented 8 years ago

Hello there, I'm not sure if I should post this issue here or if that's the case for every plugin that load images with relative paths in CSS. If I use the pipeline for CSS, I've got a 404 not found for the small external icon loaded from the CSS

image_broken_404

image_broken

Sommerregen commented 8 years ago

Hi @Birssan ,

IMHO this is a general problem, when pipelining CSS. A good parser who pipelines the code has to read all relative paths to images, fonts etc. from different CSS files and adjust them accordingly in the new pipelined CSS file.

Thus, this is either a Grav issue due to the code in Assets.php, L1042 - L1068 or a Minify issue.

You may try or check whether assets.css_rewrite: true is set to true (for reference: https://github.com/getgrav/grav/blob/6e399fe0ed41937d5b71dc330c75e40bd53b2fbc/system/config/system.yaml#L81). If the error persist, I recommend you opening an issue on the Grav issue tracker. Otherwise open an issue on the Minify project page.

seb-vial commented 8 years ago

Well yes I figured it was not because of the plugin, I should have checked that option first, sorry... I can't test it right now, I'll try that later. Thanks

Sommerregen commented 8 years ago

@Birssan Ok, no problem. Come back later, if there are any further issues.