search

Sommerregen / grav-plugin-jscomments

JSComments is a Grav (http://github.com/getgrav/grav) plugin which allows to integrate comments into individual pages from Discourse / Disqus / Facebook / Google+ / HyperComments / IntenseDebate / Isso, and Muut comment systems.
Other
29 stars 9 forks source link

JScomments Not Working with Grav Beta #1

Closed ghost closed 8 years ago

ghost commented 8 years ago

FYI ... You may already be aware, JScomments does not show in the page options tab under GRAV Beta.

Sommerregen commented 8 years ago

Hi @umbergerba ,

yes I'm already aware of. Can you change this line (https://github.com/Sommerregen/grav-plugin-jscomments/blob/master/jscomments.php#L96) to

if (false === $inEvent and $blueprint->get('form/fields/tabs', null, '/')) {
 ...
}

Further can you check, which version of JSComments you have? I've only got v1.2.10, which I'm not sure it was the "latest" and last release of this plugin. If you have a higher version can you send me a download link to it, so that I can incorporate the changes? And does the rest of the plugin works fine with the beta?

ghost commented 8 years ago

Yes, that seems to have fixed the issue I mentioned. I will test the plugin some more now and let you know if I see any other issues; so far everything else seems fine.

You have the latest version that was released (1.2.10).

Thanks! Brian U.

Sommerregen commented 8 years ago

Hi @umbergerba ,

JSComments now includes this fix. It is in the testing release. Thus, please make sure to switch to the "testing" channel in order to get the latest additions.

Thanks!