search

Sommerregen / grav-plugin-jscomments

JSComments is a Grav (http://github.com/getgrav/grav) plugin which allows to integrate comments into individual pages from Discourse / Disqus / Facebook / Google+ / HyperComments / IntenseDebate / Isso, and Muut comment systems.
Other
29 stars 9 forks source link

Wrong output code #15

Closed phideas closed 7 years ago

phideas commented 7 years ago

If using Gantry plugin, all variables are auto-escaped for security reason. Using {{ jscomments()|raw }} makes it easy to render output correctly. But translations are escaped even after this step and results in wrong output.

Please consider adding |raw after translations and make this plugin update proof for Gantry users. 'PLUGINS.JS_COMMENTS.PROVIDERS.DISQUS.NOSCRIPT'|t|raw

Sommerregen commented 7 years ago

Hi @phideas ,

To be honest I don't use Gantry. However I have added the raw filter in the develop branch. You may check it out, if you want. I will release a new version in the next days.

phideas commented 7 years ago

Very nice. Now it is "plug&play" and "update proof" for Gantry users too. Gantry is very advanced and popular plugin for Grav. I am sure many users will appreciate this patch. Thank you!

Sommerregen commented 7 years ago

Ok, I released a new version today. Have fun 🎉