search

Sommerregen / grav-plugin-mediaembed

This plugin embeds several media sites (e.g. YouTube, Vimeo, Soundcloud) by only providing the URL to the medium.
Other
24 stars 8 forks source link

Embed GitHub setting caused entire site to go offline #26

Open mikegcox opened 7 years ago

mikegcox commented 7 years ago

I have a website that worked fine for many months. One day I visited the site and it had the Crikey Error that is pasted below. To get the site to come back online I just had to turn off "Embed GitHub" in the Plugin config.

It is only this one site that has this issue and I took the entire User folder and ran it locally and I have the same issue which eliminates the possibility of it bing the hosting environment.

All is well, I am not embedding GitHub anyhow, but I thought I should mention it and maybe find the cause.

Whoops\Exception\ErrorException thrown with message "Undefined index: gist.github.com"

Stacktrace:
#16 Whoops\Exception\ErrorException in /Users/mike/Sites/ppm/user/plugins/mediaembed/classes/Service.php:226
#15 Whoops\Run:handleError in /Users/mike/Sites/ppm/user/plugins/mediaembed/classes/Service.php:226
#14 Grav\Plugin\MediaEmbed\Service:register in /Users/mike/Sites/ppm/user/plugins/mediaembed/classes/MediaEmbed.php:105
#13 Grav\Plugin\MediaEmbed\MediaEmbed:__construct in /Users/mike/Sites/ppm/user/plugins/mediaembed/mediaembed.php:93
#12 Grav\Plugin\MediaEmbedPlugin:onPluginsInitialized in /Users/mike/Sites/ppm/vendor/symfony/event-dispatcher/EventDispatcher.php:184
#11 call_user_func in /Users/mike/Sites/ppm/vendor/symfony/event-dispatcher/EventDispatcher.php:184
#10 Symfony\Component\EventDispatcher\EventDispatcher:doDispatch in /Users/mike/Sites/ppm/vendor/symfony/event-dispatcher/EventDispatcher.php:46
#9 Symfony\Component\EventDispatcher\EventDispatcher:dispatch in /Users/mike/Sites/ppm/vendor/rockettheme/toolbox/Event/src/EventDispatcher.php:23
#8 RocketTheme\Toolbox\Event\EventDispatcher:dispatch in /Users/mike/Sites/ppm/system/src/Grav/Common/Grav.php:277
#7 Grav\Common\Grav:fireEvent in /Users/mike/Sites/ppm/system/src/Grav/Common/Processors/PluginsProcessor.php:19
#6 Grav\Common\Processors\PluginsProcessor:process in /Users/mike/Sites/ppm/system/src/Grav/Common/Grav.php:126
#5 Grav\Common\Grav:Grav\Common\{closure} in /Users/mike/Sites/ppm/system/src/Grav/Common/Grav.php:368
#4 Grav\Common\Grav:Grav\Common\{closure} in /Users/mike/Sites/ppm/system/src/Grav/Common/Grav.php:344
#3 call_user_func_array in /Users/mike/Sites/ppm/system/src/Grav/Common/Grav.php:344
#2 Grav\Common\Grav:__call in /Users/mike/Sites/ppm/system/src/Grav/Common/Grav.php:127
#1 Grav\Common\Grav:measureTime in /Users/mike/Sites/ppm/system/src/Grav/Common/Grav.php:127
#0 Grav\Common\Grav:process in /Users/mike/Sites/ppm/index.php:52
Sommerregen commented 7 years ago

@mikegcox Consider MediaEmbed as being outdated. It does not work with Grav v1.x+ for now. It needs a full rewrite and better blueprints. Any help is much appreciated since I'm running out of time and I can only minimally maintain a few plugins at the moment 😭 .

adrian5 commented 7 years ago

@Sommerregen Might be helpful to update the README so users aren't left in the dark.

Sommerregen commented 7 years ago

@adrian5 Thanks for pointing this out. It is now added to the docs.

adrian5 commented 7 years ago

Cheers! It's a useful type of plugin to have, so I hope you find the time to update it in the distant future, maybe when Grav releases another major revision (From what I understand, Grav 2.0 is in the works).